Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the Timestamp.day_of_year call to use the aliased Timestamp.dayofyear to work better with different versions of pandas #397

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Changed the Timestamp.day_of_year call to use the aliased Timestamp.dayofyear to work better with different versions of pandas #397

merged 2 commits into from
Jul 19, 2023

Conversation

christophertubbs
Copy link
Contributor

Older versions of pandas don't support Timestamp.day_of_year while new versions alias Timestamp.dayofyear to it. This will change the command used to make it work well with both old and new versions of pandas

@christophertubbs christophertubbs self-assigned this Jul 18, 2023
@christophertubbs
Copy link
Contributor Author

Addresses #396

@christophertubbs christophertubbs marked this pull request as ready for review July 18, 2023 20:11
@robertbartel robertbartel merged commit 266142c into NOAA-OWP:master Jul 19, 2023
1 check passed
@christophertubbs christophertubbs deleted the use_old_timestamp_doy branch July 19, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbartel robertbartel robertbartel approved these changes

@aaraney aaraney Awaiting requested review from aaraney

Assignees

@christophertubbs christophertubbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophertubbs @robertbartel